fix(@angular-devkit/build-angular): fully remove third-party sourcemaps when disabled in esbuild builder #25015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps when disabled in esbuild builder When using the esbuild-based browser application builder, third-party sourcemaps will now be fully removed when the `sourcemap` option's `vendor` sub-option is disabled. The `vendor` sub-option is disabled by default and is only enabled if explicitly enabled within the project's configuration. Sourcemaps are considered third-party if their referencing code is contained within a `node_modules` directory. Previously, sourcemap URL comments may have been unintentionally left intact when processing third-party code via the Babel-based JavaScript transformer. These sourcemap URL comments are now removed correctly when code is both transformed and return directly when no transformation is required.
clydin
added
target: rc
alan-agius4
approved these changes
Apr 14, 2023
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the esbuild-based browser application builder, third-party sourcemaps will now be fully removed when the
sourcemapoption'svendorsub-option is disabled. Thevendorsub-option is disabled by default and is only enabled if explicitly enabled within the project's configuration. Sourcemaps are considered third-party if their referencing code is contained within anode_modulesdirectory. Previously, sourcemap URL comments may have been unintentionally left intact when processing third-party code via the Babel-based JavaScript transformer. These sourcemap URL comments are now removed correctly when code is both transformed and return directly when no transformation is required.